Greptile Summary

This PR fixes a crash in run.sh for developers who have Node.js installed via Homebrew (v22+), where the node binary is a small ~68 KB stub that dynamically loads libnode.X.dylib. The fix stages the dylib alongside the node binary, ensures it is writable for codesign, and signs it inside the app bundle before signing the node binary itself.

• prepare-agent-runtime.sh: After copying the Homebrew node stub, uses otool -L to detect a libnode dependency, locates the dylib via candidate paths (Cellar-relative and Homebrew prefix), copies it alongside the node binary, and makes it writable (chmod u+w) so the downstream codesign --force step doesn't fail with EACCES.
• run.sh: Adds a glob loop to sign any libnode.*.dylib in the node bundle dir before signing the node binary — the correct signing order — using --options runtime only (no --entitlements, as macOS reads entitlements exclusively from the main executable). Also refactors the repeated bundle dir path into a NODE_BUNDLE_DIR variable.
• .gitignore: Extends the existing Resources exclusion to cover libnode.*.dylib, preventing the ~70 MB dylib from being accidentally committed.

Confidence Score: 4/5

Safe to merge for development workflows; the fix is correctly scoped to Homebrew-installed node and has no effect on the --universal-node release path.

The signing order, entitlements handling, and gitignore entry are all correct. The open question is whether the staged dylib actually resolves at runtime — modern Homebrew node stubs use @rpath/libnode.X.dylib, and the RPATH entries in the binary determine where dyld looks. If the only matching RPATH entry is an absolute /opt/homebrew/lib path, the staged copy in the bundle is redundant during development and would still fail on a machine without Homebrew.

desktop/scripts/prepare-agent-runtime.sh — the dylib candidate search and placement logic depends on an assumption about the node stub's RPATH entries that is worth verifying.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[stage_local_node called] --> B[cp node stub to NODE_RESOURCE]
    B --> C[otool -L node_bin]
    C --> D{libnode.X.dylib dependency found?}
    D -- No, static build --> E[log version, done]
    D -- Yes, Homebrew stub --> F[Search candidates:
1. node_bin_dir/../lib/libnode.X.dylib
2. node_bin_dir/libnode.X.dylib
3. brew --prefix/lib/libnode.X.dylib]
    F --> G{Found?}
    G -- No --> H[exit 1 with error]
    G -- Yes --> I[cp dylib alongside node
chmod u+w
xattr -cr]
    I --> E

    subgraph run.sh signing order
        J[NODE_BIN exists?] --> K[for libnode.*.dylib in bundle dir]
        K --> L{file exists?}
        L -- No --> M[continue]
        L -- Yes --> N[codesign --options runtime
no entitlements]
        N --> O[codesign node binary
with entitlements]
        O --> P[codesign app bundle]
    end

_{Reviews (1): Last reviewed commit: "fix(desktop): address code review findin..." | Re-trigger Greptile}

fixed in #7812

Hey @formed2forge 👋

Thank you so much for taking the time to contribute to Omi! We truly appreciate you putting in the effort to submit this pull request.

After careful review, we've decided not to merge this particular PR. Please don't take this personally — we genuinely try to merge as many contributions as possible, but sometimes we have to make tough calls based on:

• Project standards — Ensuring consistency across the codebase
• User needs — Making sure changes align with what our users need
• Code best practices — Maintaining code quality and maintainability
• Project direction — Keeping aligned with our roadmap and vision

Your contribution is still valuable to us, and we'd love to see you contribute again in the future! If you'd like feedback on how to improve this PR or want to discuss alternative approaches, please don't hesitate to reach out.

Thank you for being part of the Omi community! 💜